Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force symbols from deploy.rb into strings to be YAML compatible #11

Merged
merged 1 commit into from
Apr 12, 2013
Merged

Force symbols from deploy.rb into strings to be YAML compatible #11

merged 1 commit into from
Apr 12, 2013

Conversation

timkelty
Copy link

From:
timkelty#1

    It's idiomatic Ruby to use symbols when possible. rails_env is usually a symbol in deploy.rb, but using a symbol makes it incompatible with the remote database.yml.

    I've stringified @cap.rails_env to fix that issue, and symbols can be used again.

sgruhier added a commit that referenced this pull request Apr 12, 2013
@sgruhier
Merge pull request #11 from timkelty/force-strings-yaml-compatibility
5186d89 
Force symbols from deploy.rb into strings to be YAML compatible
@sgruhier sgruhier merged commit 5186d89 into sgruhier:master Apr 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timkelty @sgruhier