-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of ENV['DATABASE_URL'] #54
Add support of ENV['DATABASE_URL'] #54
Conversation
Thanks for pull-request, but you did a lot of changes. I'm okay with .gitignore, but not with .editorconfig. I think it should be in your ~/.gitignore_global, because it is your personal setting + someone use vim, someone rubymine, some one prefer emacs. |
About .editorconfig: it's not about personal choice, it's about common code style for a project. For example, look at ruby repo: https://github.com/ruby/ruby/blob/trunk/.editorconfig About PR spliting: I'll try to do it |
@donbobka thanks for the explanation. You're right. |
Very nice PR. @donbobka Can I point my Gemfile to your fork? Is it stable or it will be rebased/changed to get this merged? |
I tried this PR using your branch and it works with on roles(:app) do
within release_path do
execute(:bundle, 'exec rails runner "ActiveRecord::Base.configurations[Rails.env].to_yaml" > tmp/config.yml')
db_config = capture('cat tmp/config.yml')
execute 'rm tmp/config.yml'
end
end |
…d::Base.connection as config source
issue #54 Add support of ENV['DATABASE_URL']
So, i close this PR now. |
My try to add support of environment variable
DATABASE_URL
. In my case I setDATABASE_URL
with gemfigaro
.The main change is adding servedside rake task
capistrano_db_tasks:config
that returns remote database configuration.Side-changes:
P.S.: Changes are not backward compatible with previous versions.