New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Исключение в admin.php:28 при пустом $guid (wc1c_manage_taxonomy_custom_column) #47

Open

MaximS opened this issue May 30, 2020 · 0 comments

MaximS commented May 30, 2020

function wc1c_manage_taxonomy_custom_column($columns, $column, $id) {
  if ($column == 'wc1c_guid') {
    $guid = get_woocommerce_term_meta($id, 'wc1c_guid');
    list($taxonomy, $guid) = explode('::', $guid);
    $columns .= $guid ? "<small>$guid</small>" : '<span class="na">–</span>';
  }

  return $columns;
}

Ошибка на list($taxonomy, $guid) = explode('::', $guid) при пустом guid.
Проявляется при включенной отладке php.

должно быть:

function wc1c_manage_taxonomy_custom_column($columns, $column, $id) {
  if ($column == 'wc1c_guid') {
    $guid = get_woocommerce_term_meta($id, 'wc1c_guid');
    if ($guid) { 
      list($taxonomy, $guid) = explode('::', $guid);
      $columns .= "<small>$guid</small>";
    } else {
      $columns .= '<span class="na">–</span>';
    }
  }

  return $columns;
}

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment