Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt to make drupalpod compatible with Drupal 11 #144

Closed

Conversation

goba
Copy link

@goba goba commented Mar 5, 2024

The Problem/Issue/Bug

How this PR Solves The Problem

Manual Testing Instructions

Related Issue Link(s)

Release/Deployment notes

Summary by CodeRabbit

  • Chores
    • Updated the development environment to support PHP 8.3, MariaDB 10.6, and other adjustments for enhanced performance and Drupal 11 compatibility.

Copy link

codesandbox bot commented Mar 5, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

This update introduces significant upgrades to the development environment, transitioning to newer versions of key components. Specifically, it moves from Drupal 10 to 11, upgrades PHP from version 8.1 to 8.3, and shifts MariaDB from version 10.4 to 10.6. Alongside, it includes various minor adjustments to enhance the setup, ensuring compatibility and leveraging the latest features and improvements offered by these updates.

Changes

File(s) Change Summary
.ddev/config.yaml Updated PHP to version 8.3, MariaDB to 10.6, and minor environment adjustments

🐰✨
In the land of code and byte,
Where the digital trees sway,
A rabbit hopped through the night,
Celebrating updates in its way.
"To PHP 8.3 and MariaDB 10.6, we leap!" it cheered,
"A brighter future we've engineered."
🌟🚀🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d3c2d4a and ce5e329.
Files selected for processing (1)
  • .ddev/config.yaml (1 hunks)
Additional comments: 3
.ddev/config.yaml (3)
  • 2-2: The type field has been updated to drupal11 to reflect compatibility with Drupal 11. This change aligns with the PR's objective of updating DrupalPod for Drupal 11.
  • 4-4: The php_version has been updated to "8.3". This is a necessary update to ensure compatibility with Drupal 11 and to leverage the performance and security improvements of PHP 8.3. However, it's important to verify that all PHP dependencies and custom code within the DrupalPod environment are compatible with PHP 8.3.
  • 11-11: The database.version has been updated to "10.6". This update is crucial for ensuring compatibility with Drupal 11 and taking advantage of the new features and improvements in MariaDB 10.6. It's recommended to verify that the database schema and any custom SQL queries used within the DrupalPod environment are fully compatible with MariaDB 10.6.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ce5e329 and fffbd7a.
Files selected for processing (1)
  • .ddev/config.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .ddev/config.yaml

@goba
Copy link
Author

goba commented Mar 5, 2024

This still leads to the following error, but manual site installation works on Drupal 11-dev.

[error]  The submitted value mysql in the Database type element is not allowed. 

In install.core.inc line 964:
                                                                                                                                    
  The submitted value <em class="placeholder">mysql</em> in the <em class="placeholder">Database type</em> element is not allowed.  
                                                                                                                                    

@goba
Copy link
Author

goba commented Mar 5, 2024

Screenshot 2024-03-05 at 10 41 02

@mradcliffe
Copy link
Contributor

Thanks to Gábor's work on this, I could guide a few people making these changes manually when running DrupalPod both via the extension and not to get working environments.

@shaal shaal mentioned this pull request Apr 19, 2024
@shaal shaal closed this in #146 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants