Restore missing quotations from Dr. Sant Singh Khalsa English Translation #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Many quotations (indicating conversations) were missing. Removed captilization from sentences that span multiple lines.
sarabveer
added
Scope: Data/Sri Guru Granth Sahib Ji
○ Type Bug
Harjot1Singh
approved these changes
Feb 10, 2019
| @@ -339,7 +339,7 @@ | |||
| "translations": { | |||
| "English": { | |||
| "Dr. Sant Singh Khalsa": { | |||
| "translation": "O my Lord, please save me!||1||Pause||", | |||
| "translation": "O my Lord, please save me!\" ||1||Pause||", | |||
There was a problem hiding this comment.
It’s a bit weird that quotes can span multiple lines
This comment was marked as abuse.
This comment was marked as abuse.
bhajneet
approved these changes
Feb 10, 2019
Your words are encouraging. If you'd like to learn more or discuss please message us using the contact info on our GitHub profile. |
|
This was done by having a script go through a text dump of the Shabad OS Dr. Sant Singh Khalsa translation and a text dump of the PDF. |
This comment was marked as abuse.
This comment was marked as abuse.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore missing quotations from Dr. Sant Singh Khalsa's English Translation. Many quotations (indicating conversations or speech) were missing, most possibly an error during importing of the database.
Also removed capitalization from sentences that span multiple lines to stay close to the original translation.
These were supposed to be 2 separate commits.
Reference: English Translation of SGGS - One Volume (Dr. Sant Singh Khalsa).pdf