Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Bhai Nand Lal #844

Merged
merged 8 commits into from
Jun 30, 2019
Merged

Import Bhai Nand Lal #844

merged 8 commits into from
Jun 30, 2019

Conversation

sarabveer
Copy link
Collaborator

Will add Bhai Nand Lal texts to Database.

Not all will be added, will be imported later.

@sarabveer
feat(data): Update Bhai Nand Lal Sources
6b899db 
- Add multiple Rehitname sources to sources.json
@sarabveer sarabveer mentioned this pull request Jun 20, 2019
Closed
bhajneet
bhajneet previously approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@bhajneet bhajneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of spelling errors, at some point we should be running spell check with our own custom dictionary to fix the english translations. Otherwise approved.

@bhajneet bhajneet mentioned this pull request Jun 24, 2019
Open
@sarabveer
Copy link
Collaborator Author

@Harjot1Singh need to convert the Punjabi translation to Unicode before merge.

@Harjot1Singh Harjot1Singh self-assigned this Jun 28, 2019
@Harjot1Singh
Copy link
Member

@sarabveer done

bhajneet
bhajneet approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@bhajneet bhajneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations lgtm

@sarabveer
Copy link
Collaborator Author

@Harjot1Singh LGTM

@sarabveer sarabveer changed the title [WIP] Import Bhai Nand Lal Import Bhai Nand Lal Jun 29, 2019
@Harjot1Singh Harjot1Singh merged commit 1e6403c into master Jun 30, 2019
@Harjot1Singh Harjot1Singh deleted the import-nand-lal branch June 30, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhajneet bhajneet bhajneet approved these changes

@Harjot1Singh Harjot1Singh Awaiting requested review from Harjot1Singh

Assignees

@Harjot1Singh Harjot1Singh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarabveer @Harjot1Singh @bhajneet