Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Improve ring/outline behavior when NOT using keyboard #4223

Closed
2 tasks done
zommerberg opened this issue Jul 9, 2024 · 1 comment
Closed
2 tasks done

[feat]: Improve ring/outline behavior when NOT using keyboard #4223

zommerberg opened this issue Jul 9, 2024 · 1 comment

Comments

@zommerberg
Copy link

zommerberg commented Jul 9, 2024

Feature description

When the keyboard isn't used for navigating the app, the ring/outline should remain hidden when selecting an item from a menu or clicking outside the menu without making a selection. In the video below, you can see that the ring appears even though I didn't use the keyboard to navigate. This forces the user to make an extra click to remove the ring. Unfortunately, I can't find a way to display the ring only on keyboard focus.

Here's an example:

Recording.2024-07-09.134100.mp4

Ideally, it should behave like in libraries such as Catalyst UI, where the ring appears only if the component was initially focused via keyboard. In that case, the ring remains even after selecting an item. However, if the component is selected using a mouse, the ring should never appear.

Recording.2024-07-09.103219.mp4

Affected component/components

Select, Dropdown

Additional Context

Additional details here...

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues and PRs
@zommerberg
Copy link
Author

It turned out to be a radix issue.

radix-ui/primitives#1803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants