Upgrade glslang 11.16.0+ #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er or shared variable. Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
…der5. Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
Bug: chromium:1203071
Fix per-set argument parsing in standalone
Fix some instances of -Wunused-but-set-variable.
Fix OpImageRead result type when compiling HLSL - Per the Vulkan spec, OpImageRead must return a 4-component vector always. When compiling HLSL, loads from a RWTexture of a template type with < 4 components would incorrectly generate an OpImageRead with a < 4 component result, resulting in validation errors. - This was previously fixed for OpImageFetch in commit 4425f24; this commit does the same thing for OpImageRead. - Added associated tests and expanded existing image fetch tests to check all the different types of textures, in both float and int incarnations, for completeness. - Update other HLSL tests involving OpImageRead
Full vector and fully specified vector swizzle stores are not affected by this change, only partial swizzles ie swizzles with fewer components than the vector being stored to. Previously the vector being stored to loaded and any components not specified in the swizzle were used to create a full store to the vector. While this change generates more SPIR-V instructions, it is necessary for correctness. Fixes KhronosGroup#2518.
Generate separate stores for partially swizzled memory stores
Support Uint to Int implicit conversions at #extension GL_ARB_gpu_shader5.
Atomic memory function can only be used for shader storage block member or shared variable.
…ntime_override_optional add possibility to not override runtime of MSVC
Allow layout(std430) uniform with GL_EXT_scalar_block_layout
Add support for pragma STDGL invariant(all)
…sic functions. refs: https://www.khronos.org/registry/OpenGL/extensions/ARB/ARB_shader_atomic_counter_ops.txt Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
Checked REGEX REPLACE for consistency failure
Seen with += and ++ ops on swizzled lvalues. Was using stale access chain. Fixes 2725.
Fix seperate stores to swizzled lvalue.
Update CMakeLists.txt
Add support for GL_NV_ray_tracing_motion_blur.
Support the atomic_counter_xxxARB built-in functons at #extension GL_ARB_shader_atomic_counter_ops.
Update known goods and CHANGES for 11.6.0
Fix -Wsign-compare warnings. Fix -Wunused-parameter warnings.
Perform update_precision on constructors and converts
MINGW_HAS_SECURE_API can be defined as 0, but this will be ignored here without this change. Without these *_s "safe" functions, this code will also build on Windows XP.
Run update_precision() on array and matrix constructors.
…re/master Change MINGW_HAS_SECURE_API checks.
…nings Fix GCC warnings
When using GL_EXT_vulkan_glsl_relaxed, check to see if a uniform already exists in the block uniform block, and if so, ensure they are the same type. Otherwise, avoid growing the block with a duplicate.
instead of allowing for multiple declarations of the variable in the resulting SPIR-V, instead use a retargeted mechanism to cause references to gl_VertexID and gl_InstanceID to use the gl_VertexIndex and gl_InstanceIndex symbol.
…licateUniform GL_EXT_vulkan_glsl_relaxed - avoid growing the global uniform block with duplicates
GL_EXT_vulkan_glsl_relaxed - retarget gl_VertexID to gl_VertexIndex
Fix SPIR-V for HLSL SampleBias
…izeArrayTesselationStageHandling Fix isIoResizeArray() tessellation stage handling
* add ability to upgrade uniform block to push constants assuming it fits within the size limit imposed by the caller * allow selecting the packing for the auto push constants * check the size using the potential layout packing of the push constants
Fix unreachable code in getSampledType()
Fix variable scoping of do-while
… feature/glslang-0.16.0+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to glslang 11.16.0, plus some subsequent PRs up to KhronosGroup#2768