Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12 release tarballs are missing the new man/uk subdirectory #547

Closed
arachsys opened this issue Aug 11, 2022 · 4 comments
Closed

4.12 release tarballs are missing the new man/uk subdirectory #547

arachsys opened this issue Aug 11, 2022 · 4 comments

Comments

@arachsys
Copy link

arachsys commented Aug 11, 2022

The missing man/uk subdirectory in the tarballs breaks configure completely:

$ ./configure
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
[...]
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating po/Makefile.in
config.status: creating doc/Makefile
config.status: creating man/Makefile
config.status: creating man/config.xml
config.status: creating man/po/Makefile
config.status: creating man/cs/Makefile
config.status: creating man/da/Makefile
config.status: creating man/de/Makefile
config.status: creating man/es/Makefile
config.status: creating man/fi/Makefile
config.status: creating man/fr/Makefile
config.status: creating man/hu/Makefile
config.status: creating man/id/Makefile
config.status: creating man/it/Makefile
config.status: creating man/ja/Makefile
config.status: creating man/ko/Makefile
config.status: creating man/pl/Makefile
config.status: creating man/pt_BR/Makefile
config.status: creating man/ru/Makefile
config.status: creating man/sv/Makefile
config.status: creating man/tr/Makefile
config.status: error: cannot find input file: `man/uk/Makefile.in'
$ curl -sL https://github.com/shadow-maint/shadow/releases/download/4.12/shadow-4.12.tar.gz | tar -t -f - | grep uk
shadow-4.12/man/po/uk.po
shadow-4.12/po/uk.gmo
shadow-4.12/po/uk.po
$

Although missing from the tarballs, man/uk/Makefile.am is present in the repository at the release tag:

$ curl -sL https://github.com/shadow-maint/shadow/archive/refs/tags/4.12.tar.gz | tar -t -f - | grep man/uk
shadow-4.12/man/uk/
shadow-4.12/man/uk/Makefile.am
$
@jubalh
Copy link
Member

jubalh commented Aug 12, 2022

Confirmed. I get:

configure.ac:700: error: required file 'man/uk/Makefile.in' not found

BTW I see that #532 didn't add uk to https://github.com/shadow-maint/shadow/blob/master/man/Makefile.am#L4

hallyn added a commit to hallyn/shadow that referenced this issue Aug 12, 2022
Closes shadow-maint#547

Signed-off-by: Serge Hallyn <serge@hallyn.com>
@hallyn hallyn closed this as completed in ef79a4d Aug 12, 2022
@hallyn
Copy link
Member

hallyn commented Aug 12, 2022

Thanks - I'll release 4.12.1 hopefully in a few days with this fix.

@jubalh
Copy link
Member

jubalh commented Aug 15, 2022

Works fine in 4.12.1! Thanks!

@hallyn
Copy link
Member

hallyn commented Aug 15, 2022

fwiw I've also added to my 'release steps' file a note to actually test configure && make && make install from the dist tar.gz.

cgzones added a commit to cgzones/shadow that referenced this issue Aug 15, 2022
Should avoid issues like shadow-maint#547
cgzones added a commit to cgzones/shadow that referenced this issue Aug 15, 2022
Should avoid issues like shadow-maint#547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants