Only free sgent if it was initialized #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sgent` is only initialized in `get_group()` if `is_shadowgrp` is true. So we should also only attempt to free it if this is actually the case. Can otherwise lead to: ``` free() double free detected in tcache 2 (gpasswd) ```
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Sep 22, 2021
https://build.opensuse.org/request/show/920286 by user jubalh + dimstar_suse - bsc#1190146: Fix empty subid range Add shadow-4.9-useradd-subuid.patch shadow-maint/shadow#399 - bsc#1190145: Fix double free in gpasswd: Add shadow-4.9-sgent-free.patch upstreamed as shadow-maint/shadow#417 - Fix shadow-login_defs-check.sh: In the last update we switched from calling make to %make_build macro. Using sed to adapt the spec file now. - libsubid-devel: add missing requires for libsubid3 - Remove README.changes-pwdutils, all distros you can upgrade from use already shadow - login.defs: Enable USERGROUPS_ENAB and CREATE_HOME to be compatible with other Linux distros and the other tools creating user accounts in use on openSUSE. Set HOME_MODE to 700 for security reasons and compatibility. [bsc#1189139] [bsc
|
Thanks! I shouldn't have taken several of those patches. Freeing memory right Would the result be more future-proof if we just memset sgent to 0 at |
Most likely would be. I also thought about doing this for this patch, but saw that it has been done this way on some other locations and adhered to it. |
|
Ok, will merge as is - thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sgentis only initialized inget_group()ifis_shadowgrpis true.So we should also only attempt to free it if this is actually the case.
Can otherwise lead to: