copy_tree: Fix regressions #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression introduced in faeab50 for setups configured without acl support.
Fixes regression introduced in faeab50. If a directory contains fifos, then openat blocks until the other side of the fifo is connected as well. This means that users can prevent "usermod -m" from completing if their home directories contain at least one fifo.
cgzones
approved these changes
Sep 9, 2022
ikerexxe
approved these changes
Sep 9, 2022
|
@hallyn It would be nice to have tagged releases when similar regressions are fixed. Most likely distros would like to fix such regressions ASAP. |
|
Oh, has it been that long? Sure, I'll do a new release. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 9, 2022
https://build.opensuse.org/request/show/1034152 by user jubalh + dimstar_suse - Add shadow-copytree-usermod-fifo.patch: Fix regression that prevented `usermod -m` to work when their home directory contained at least one fifo See shadow-maint/shadow#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes regressions in copy_tree:
./configure --without-aclleads to a usermod which does not work due to invalid chmod call.usermod -md /new_home userfrom working.Please see commit messages for more details.