Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: add a few more generated files to be ignored #972

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

eli-schwartz
Copy link
Contributor

before this, the following untracked files showed up in git status:

lib/atoi/.dirstamp
lib/string/.dirstamp
lib/time/.dirstamp
man/da/login.defs.d
man/da/messages.mo
man/de/login.defs.d
man/de/messages.mo
man/fr/login.defs.d
man/fr/messages.mo
man/it/login.defs.d
man/it/messages.mo
man/pl/login.defs.d
man/pl/messages.mo
man/ru/login.defs.d
man/ru/messages.mo
man/sv/login.defs.d
man/sv/messages.mo
man/uk/login.defs.d
man/uk/messages.mo
man/zh_CN/login.defs.d
man/zh_CN/messages.mo
test-driver

@eli-schwartz eli-schwartz mentioned this pull request Mar 17, 2024
Copy link
Collaborator

@alejandro-colomar alejandro-colomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Alejandro Colomar <alx@kernel.org>

@alejandro-colomar
Copy link
Collaborator

alejandro-colomar commented Mar 17, 2024

Hmmm, actually, there are '*.d' files that we want. Well, they're actually directories.

alx@debian:~/src/shadow/shadow/master$ git clean -dffx
alx@debian:~/src/shadow/shadow/master$ find -type f | grep '\.d$' | wc -l
0
alx@debian:~/src/shadow/shadow/master$ find -type d | grep '\.d$' | wc -l
124

I'm not sure adding *.d is a good idea.

@alejandro-colomar
Copy link
Collaborator

We're fine with *.mo:

alx@debian:~/src/shadow/shadow/master$ find -type d | grep '\.mo$' | wc -l
0
alx@debian:~/src/shadow/shadow/master$ find -type f | grep '\.mo$' | wc -l
0

@alejandro-colomar alejandro-colomar dismissed their stale review March 17, 2024 23:37

doubts about *.d

@eli-schwartz
Copy link
Contributor Author

For some reason I thought those were depfiles, and I'm not sure why.

login.defs.d:
        ln -sf $(srcdir)/../login.defs.d login.defs.d

This appears to be using it as a way of relativizing itstool includes. Interesting.

before this, the following untracked files showed up in `git status`:

	lib/atoi/.dirstamp
	lib/string/.dirstamp
	lib/time/.dirstamp
	man/da/login.defs.d
	man/da/messages.mo
	man/de/login.defs.d
	man/de/messages.mo
	man/fr/login.defs.d
	man/fr/messages.mo
	man/it/login.defs.d
	man/it/messages.mo
	man/pl/login.defs.d
	man/pl/messages.mo
	man/ru/login.defs.d
	man/ru/messages.mo
	man/sv/login.defs.d
	man/sv/messages.mo
	man/uk/login.defs.d
	man/uk/messages.mo
	man/zh_CN/login.defs.d
	man/zh_CN/messages.mo
	test-driver

Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Reviewed-by: Alejandro Colomar <alx@kernel.org>
@eli-schwartz
Copy link
Contributor Author

range-diff:

1:  5150ac18 ! 1:  7cd7e5d5 gitignore: add a few more generated files to be ignored
    @@ .gitignore: lib*.a
     +*.mo
      *.gmo
      .deps
    -+*.d
      .libs
     +.dirstamp
      
    @@ .gitignore: Makefile.in
      /ylwrap
      
      /po/*.header
    +
    + ## man/.gitignore ##
    +@@ man/.gitignore: generate_mans.deps
    + 
    + *.[0-9]
    + 
    ++# translation symlinks
    ++/*/login.defs.d
    ++
    + /po/POTFILES
    + /po/stamp-po

This ignores only subdirectories of man/*/ and not man/login.defs.d itself.

@hallyn hallyn merged commit e44a9e6 into shadow-maint:master Mar 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants