Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed condition for useProxy #2221

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Fixed condition for useProxy #2221

merged 2 commits into from
Feb 24, 2019

Conversation

DamirAinullin
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

Fixed condition for useProxy. "==" instead od "=".

@celeron533
Copy link
Contributor

Hi @DamirAinullin , thanks for the pull request.
You PR changed the logic which may not satisfy the original design.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More clear than original code. if(a=b) just looks like a typo of if(a==b).

@celeron533 celeron533 merged commit 94cc6c5 into shadowsocks:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants