Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: add spawn and item id's #31

Closed
Artur91425 opened this issue Nov 17, 2017 · 4 comments
Closed

browser: add spawn and item id's #31

Artur91425 opened this issue Nov 17, 2017 · 4 comments

Comments

@Artur91425
Copy link
Contributor

Artur91425 commented Nov 17, 2017

Please add id in browser. Something like that:
bandicam 2017-11-17 21-12-54-651
This will help you quickly find out the id by name and find on the Internet quickly the information you need.
It would also be very convenient to do a two-way search. By name and by id.

@shagu shagu changed the title browser: add id browser: add spawn and item id's Nov 17, 2017
@Artur91425
Copy link
Contributor Author

And for quests :)

@Muehe
Copy link
Contributor

Muehe commented Nov 25, 2017

I have a semi-complete solution for this by using the tooltips of the search results. It works for items and quests (adds additional values and formatting for quests too):

pfquest itemtooltip
pfquest questtooltip

Couldn't show IDs for spawns, because they are not in the DB file, but I added some other stuff:

pfquest spawntooltip

@Artur91425
Copy link
Contributor Author

Artur91425 commented Nov 25, 2017

The information in the tooltip looks very good, I like it. But I think that also need to add the ID to the browser. It will be more convenient and clearer. And if implement a two-way search, then it will be great :)

@Muehe
Copy link
Contributor

Muehe commented Nov 28, 2017

How about this (also adds quest level colored according to difficulty):

screenshot_2017-11-28_20-26-04
screenshot_2017-11-28_20-40-08

diff --git a/pfBrowser.lua b/pfBrowser.lua
index 3fb247b..0e2bde4 100644
--- a/pfBrowser.lua
+++ b/pfBrowser.lua
@@ -708,7 +708,7 @@ function pfBrowser:SearchItem(search)
               ITEM_QUALITY_COLORS[itemQuality].g * 255,
               ITEM_QUALITY_COLORS[itemQuality].b * 255)
 
-          this.text:SetText(this.itemColor .."|Hitem:"..this.itemID..":0:0:0|h[".. this.itemName.."]|h|r")
+          this.text:SetText(this.itemColor .."|Hitem:"..this.itemID..":0:0:0|h[".. this.itemName.."]|h|r |cff9d9d9d("..this.itemID..")|r")
           this.text:SetWidth(this.text:GetStringWidth())
           this:SetScript("OnUpdate", nil)
         end
@@ -764,7 +764,7 @@ function pfBrowser:SearchQuest(search)
       end
 
       if quests[quest] then
-        button.text:SetText("|cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r")
+        button.text:SetText(pfDatabase:HexDifficultyColor(quests[quest]["lvl"]).."["..quests[quest]["lvl"].."]|r |cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r |cff9d9d9d("..quests[quest]["id"]..")|r")
       else
         button.text:SetText("|cffff5555[?] |cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r")
       end

As with the tooltips, the spawns lack the ID to show, and I haven't had time to set up all the stuff required for a full extract, so I can't do anything about that for now.

Muehe added a commit to Muehe/pfQuest that referenced this issue Feb 27, 2018
* ID is always shown in tooltips.
* ID is only shown in result buttons when the new config option is enabled.
* Config option is to be used from node tooltips later.
* This closes shagu#31.
shagu pushed a commit that referenced this issue Mar 1, 2018
* ID is always shown in tooltips.
* ID is only shown in result buttons when the new config option is enabled.
* Config option is to be used from node tooltips later.
* This closes #31.
@shagu shagu closed this as completed in 55163b8 Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants