-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser: add spawn and item id's #31
Comments
And for quests :) |
I have a semi-complete solution for this by using the tooltips of the search results. It works for items and quests (adds additional values and formatting for quests too): Couldn't show IDs for spawns, because they are not in the DB file, but I added some other stuff: |
The information in the tooltip looks very good, I like it. But I think that also need to add the ID to the browser. It will be more convenient and clearer. And if implement a two-way search, then it will be great :) |
How about this (also adds quest level colored according to difficulty): diff --git a/pfBrowser.lua b/pfBrowser.lua
index 3fb247b..0e2bde4 100644
--- a/pfBrowser.lua
+++ b/pfBrowser.lua
@@ -708,7 +708,7 @@ function pfBrowser:SearchItem(search)
ITEM_QUALITY_COLORS[itemQuality].g * 255,
ITEM_QUALITY_COLORS[itemQuality].b * 255)
- this.text:SetText(this.itemColor .."|Hitem:"..this.itemID..":0:0:0|h[".. this.itemName.."]|h|r")
+ this.text:SetText(this.itemColor .."|Hitem:"..this.itemID..":0:0:0|h[".. this.itemName.."]|h|r |cff9d9d9d("..this.itemID..")|r")
this.text:SetWidth(this.text:GetStringWidth())
this:SetScript("OnUpdate", nil)
end
@@ -764,7 +764,7 @@ function pfBrowser:SearchQuest(search)
end
if quests[quest] then
- button.text:SetText("|cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r")
+ button.text:SetText(pfDatabase:HexDifficultyColor(quests[quest]["lvl"]).."["..quests[quest]["lvl"].."]|r |cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r |cff9d9d9d("..quests[quest]["id"]..")|r")
else
button.text:SetText("|cffff5555[?] |cffffcc00|Hquest:0:0:0:0|h[" .. questname .. "]|h|r")
end
As with the tooltips, the spawns lack the ID to show, and I haven't had time to set up all the stuff required for a full extract, so I can't do anything about that for now. |
* ID is always shown in tooltips. * ID is only shown in result buttons when the new config option is enabled. * Config option is to be used from node tooltips later. * This closes shagu#31.
* ID is always shown in tooltips. * ID is only shown in result buttons when the new config option is enabled. * Config option is to be used from node tooltips later. * This closes #31.
Please add id in browser. Something like that:
This will help you quickly find out the id by name and find on the Internet quickly the information you need.
It would also be very convenient to do a two-way search. By name and by id.
The text was updated successfully, but these errors were encountered: