-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVBSUB tests #903
Comments
Sorry @cooliobr for hijacking but I might be having the same issue (only I am using dash, not hls) I also attempted to test dvbsubs using lastest master for live streams and failed. While packager did not complain of any error, it didnt create the init segment nor the directory (according to the segment_template), also, the track was not mentioned in the generated MPD. Is this supposed to work for live?
Thank you |
Looks like there are two separate problems. @jakubvojacek Can you try if you can capture the source stream and re-produce the problem using the captured stream? It can help us debug the issue. Can you also file a separate issue instead? For the problem posted by @cooliobr, @TheModMaker Do you know if Shaka Player supports ttml in mp4 with image? |
I thing the better way is keep dvbsub track inside of audio track like i do it with ffmpeg, i encrypt only VIDEO, AUDIO and SUB i keep without encryption exoplayer and some web player can be used. |
The problem with keeping the DVB data in the audio track is that it isn't supported by many (or any) web players. Shaka Player definitely doesn't and others probably don't either. Also, there is no standard for indicating the DVB subtitles are present in either DASH or HLS; there is an indicator for CEA though. So a more cross-player way to allow playback on more players is to convert to a more supported format like TTML. I just tested again with TTML+MP4 and it works fine for me with VOD in Shaka Player. It's possible Live could cause problems with timestamps. The input could be not synchronized, or we may be mis-handling the timestamps, or Shaka Player might be. If you could provide a reproducible sample to test with, that would help. |
This is a live transmission with new packager if need a live source i can provide.
|
So there are a few bugs here. First, we are inserting I'll make a patch to fix our generation, but using fMP4 might have some problems in Shaka Player. |
Issue #903 Change-Id: I1f73d16ad79c2593996d7d50f9556984302fe21e
I'm trying to test the new DVBSUB functionality, without success. I believe I better put here my case instead of creating another ticket. Here's my setup:
Here's the output I get:
Same happens when I try using ffmpeg as udp live stream server as packager input. I got that file looking for |
@Canta That is actually a different problem. Your problem is caused by the incorrect handling of MPEG-1 audio. Can you file a separate bug instead? |
@Canta Thanks for the update. As mentioned by @TheModMaker in #903 (comment), Shaka Player has problems handling TTML with HLS right now. You may follow the link shared by @TheModMaker to see the details. To test the playback, you may package the output to DASH, which should be properly supported in Shaka Player right now. |
@kqyang
Shaka player later behaves the same: You can test the command with the provided
|
@TheModMaker What do you think? |
What is probably happening is either we are misinterpreting the background color or your content has that as the color. For the size, we use the viewport size to determine what the video size is and scale as a percentage of that. We may be using that wrong or your content may not set that properly. I'll take a look on Monday. For sample content, I used https://www.ccextractor.org/public:general:tvsamples. Some of the content didn't play because it is interlaced or the MPEG-1 errors above. The |
This is working as intended. Please try with the latest |
Oh, I was just using shaka player's demo app, in its nightly version: You can pick other versions to test, here: |
I also tested the packager with nightly version of the player and subtitles worked fine exept that green background colour on subtitles where background should be totally transparent and not visible. Is there any other player supporting these subtitles to confirm whether the problem is in the packager or player ? |
@kepppis Can you provide the source content and the packaged contents? We can triage and figure out where the problem could be. |
Sure, I try to prepare the samples tomorrow. With another source (YLE in Finland) I run into following error [0322/224656:ERROR:dvb_image.cc(215)] DVB-sub image cannot fit in region/window Is it to send the samples in email as the content is copyrighted ? |
Yes, you can send the samples to shaka-packager-issues@google.com if they cannot be shared publicly. |
Hi guys, thanks for all support i faced with same problem in subtitle with green background but this problem appears only in one of my script. |
I can confirm now that the background problem is fixed. The other issue where the package stops with error |
i faced this problem when i use packager in HBO and Cinemax ( both in
subtitle 0 ) if i select only subtitle 1 work ok.
"Não existe patch para a estupidez humana"
Em ter., 30 de mar. de 2021 às 08:51, Esa Pekkarinen <
***@***.***> escreveu:
… I can confirm now that the background problem is fixed. The other issue
where the package stops with error
[0322/224656:ERROR:dvb_image.cc(215)] DVB-sub image cannot fit in
region/window is still there. It can be reproduced with the other sample I
sent you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBIDCVP5HJDDAMCWUJ4MX3TGG3NZANCNFSM4X4UVZSA>
.
|
Hi guys,
|
I'm adding one more test with a different sample. However, a sample from the Kika channel turns out a bit choppy now and then. I was only able to make it work (both file4 and this sample) using ttml as the segment template. I used this test tool to test the stream (streamed locally from my PC) Original file, kika.ts played on VLC How to package I also had to previous demux both streams as the packager failed to demux properly. Another bug. Input #0, mpegts, from 'kika.ts': ffmpeg -i kika.ts -map 0:0 -vcodec copy -muxdelay 0 -copyts kika_video.ts |
Same issue over here, regardless of the -canvas_size setting in ffmpeg. |
@TheModMaker @joeyparrish any pointers? |
It sounds like the original issue was addressed and any remaining outstanding issues are covered by #1195 so going to close this one and continue that work there |
System info
Ubuntu 16.04
shaka-packager version 025e10d-release
about dvbsub, which player can I test? I’ve already tested Shaka Player and Exoplayer, neither of them showed subtitles
#!/bin/bash
CONTENT_ID=
echo $1 | tr -d '\n' | xxd -p
PWD=/usr/local/nginx/html/live/$1
rm $PWD/*
/usr/local/src/shaka_packager/src/out/Release/packager
'in=udp://127.0.0.2:1234?reuse=1,stream=text,skip_encryption=1,format=ttml+mp4,init_segment=text_init.mp4,segment_template=text_$Number$.'$2',playlist_name=text.m3u8'
'in=udp://127.0.0.2:1234?reuse=1,stream=0,skip_encryption=1,init_segment=audio_init_0.mp4,segment_template=audio_0_$Number$.m4s,hls_name=POR,playlist_name=audio0.m3u8'
'in=udp://127.0.0.2:1234?reuse=1,stream=1,skip_encryption=1,init_segment=audio_init_1.mp4,segment_template=audio_1_$Number$.m4s,hls_name=EN,playlist_name=audio1.m3u8'
'in=udp://127.0.0.2:1237?reuse=1,stream=video,init_segment=720p_init.mp4,segment_template=720p_$Number$.m4s,playlist_name=720p.m3u8'
'in=udp://127.0.0.2:1235?reuse=1,stream=video,init_segment=360p_init.mp4,segment_template=360p_$Number$.m4s,playlist_name=360p.m3u8'
'in=udp://127.0.0.2:1234?reuse=1,stream=video,init_segment=180p_init.mp4,segment_template=180p_$Number$.m4s,playlist_name=180p.m3u8'
--hls_master_playlist_output playlist.m3u8
--hls_playlist_type LIVE
--default_language por
--default_text_language por
--time_shift_buffer_depth 60
--enable_widevine_encryption
--key_server_url https://license.uat.widevine.com/cenc/getcontentkey/widevine_test
--content_id $CONTENT_ID
--signer widevine_test
--aes_signing_key 1ae8ccd0e7985cc0b6203a55855a1034afc252980e970ca90e5202689f947ab9
--aes_signing_iv d58ce954203b7c9a9a9d467f59839249
--protection_systems Widevine >> $PWD/$1.log 2>&1 &
output
#EXTM3U
Generated with https://github.com/google/shaka-packager version 025e10d-release
#EXT-X-INDEPENDENT-SEGMENTS
#EXT-X-MEDIA:TYPE=AUDIO,URI="audio0.m3u8",GROUP-ID="default-audio-group",NAME="POR",AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,URI="audio1.m3u8",GROUP-ID="default-audio-group",NAME="EN",CHANNELS="2"
#EXT-X-MEDIA:TYPE=SUBTITLES,URI="text.m3u8",GROUP-ID="default-text-group",NAME="stream_2",AUTOSELECT=YES
#EXT-X-STREAM-INF:BANDWIDTH=613945,AVERAGE-BANDWIDTH=574088,CODECS="avc1.4d401e,mp4a.40.2,ttml",RESOLUTION=640x360,FRAME-RATE=29.970,AUDIO="default-audio-group",SUBTITLES="default-text-group"
360p.m3u8
#EXT-X-STREAM-INF:BANDWIDTH=3121216,AVERAGE-BANDWIDTH=2922061,CODECS="avc1.4d401f,mp4a.40.2,ttml",RESOLUTION=1280x720,FRAME-RATE=29.970,AUDIO="default-audio-group",SUBTITLES="default-text-group"
720p.m3u8
#EXT-X-STREAM-INF:BANDWIDTH=754066,AVERAGE-BANDWIDTH=707786,CODECS="avc1.4d400d,mp4a.40.2,ttml",RESOLUTION=320x180,FRAME-RATE=29.970,AUDIO="default-audio-group",SUBTITLES="default-text-group"
180p.m3u8
The text was updated successfully, but these errors were encountered: