Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS SUBTITLES listed in CODECS not supported #3184

Closed
TheModMaker opened this issue Feb 26, 2021 · 5 comments
Closed

HLS SUBTITLES listed in CODECS not supported #3184

TheModMaker opened this issue Feb 26, 2021 · 5 comments
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@TheModMaker
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.0.8

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
N/A

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
https://storage.googleapis.com/shaka-demo-assets/_bugs/ttml_mp4_hls/foo.m3u8

What did you do?
Try to play asset that has the subtitle codecs listed in the CODECS string for the stream. For example CODECS="avc1.4d401e,stpp.ttml.im1t".

What did you expect to happen?
Asset plays.

What actually happened?
CONTENT_NOT_SUPPORTED_BY_BROWSER. What happens is the codec is treated as part of the audio+video and we query MSE for support. We should be stripping this out of the codec list. Additionally, related to #1959, we should be using this info to determine which MP4 parser to use.

FYI, this is related to Shaka Packager live subtitles in shaka-project/shaka-packager#832. I'm not an HLS expert, so this may be bad content too.

@TheModMaker TheModMaker added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles labels Feb 26, 2021
@TheModMaker TheModMaker added this to the v3.2 milestone Feb 26, 2021
@TheModMaker
Copy link
Contributor Author

The error may only be caused by us thinking the content is audio+video since there isn't an audio stream and that is the audio codec. I think it works with different audio and video streams, see shaka-project/shaka-packager#903 (comment).

@joeyparrish
Copy link
Member

Should be easy enough to filter out common text codecs there and fix the multiplex detection in the HLS parser.

@ismena ismena self-assigned this Mar 11, 2021
@ismena
Copy link
Contributor

ismena commented Mar 16, 2021

I might be misunderstanding, but this looks like bad content to me.
There's a variant tag and a subtitle media tag.
This is the variant tag:
EXT-X-STREAM-INF:BANDWIDTH=1120520,AVERAGE-BANDWIDTH=1018680,CODECS="avc1.4d401e,stpp.ttml.im1t",RESOLUTION=640x360,FRAME-RATE=29.970,SUBTITLES="default-text-group"
FRAMERATE and RESOLUTION attributes suggest a video stream, but the only codec present is an audio codec.

Looking at the media playlist, it seems to be a video mp4 stream. If that's the case, I'd expect a video codec instead of an audio one.

@TheModMaker
Copy link
Contributor Author

avc1.4d401e is a video codec, it is H.264; the other codec (stpp.ttml.im1t) is TTML.

@ismena
Copy link
Contributor

ismena commented Mar 16, 2021

Ack. Will look into it.

joeyparrish pushed a commit that referenced this issue Apr 22, 2021
Closes #3184

Change-Id: I42454318efa5e87eeff174e2f43218bb194c4c8d
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 17, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants