Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI parsing in HLS parser #1085

Closed
joeyparrish opened this issue Oct 24, 2017 · 0 comments
Closed

Fix URI parsing in HLS parser #1085

joeyparrish opened this issue Oct 24, 2017 · 0 comments
Assignees
@joeyparrish
Labels
component: HLS The issue involves Apple's HLS manifest format flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.3.0

Comments

@joeyparrish
Copy link
Member

Raised in #887 (comment)

Currently, the HLS parser uses split() to get the extension from a segment URI and guess at the MIME type based on that. This doesn't account for URL parameters, though, so we should use the goog.uri parser we already have for this.
@joeyparrish joeyparrish added type: bug Something isn't working correctly flag: good first issue This might be a relatively easy issue; good for new contributors component: HLS The issue involves Apple's HLS manifest format labels Oct 24, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Oct 24, 2017
@joeyparrish joeyparrish mentioned this issue Oct 24, 2017
Closed
@joeyparrish joeyparrish self-assigned this Oct 25, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: HLS The issue involves Apple's HLS manifest format flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot