-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select by role as well as language without disabling ABR #412
Comments
If you select a track using player.configure({preferredAudioLanguage: 'es'}) In the demo app, selecting a track from the drop-down list will use |
That's right. If your UI had manual track selection widget (like YouTube's 360p / 480p / 720p / 1080p / auto), that would connect to If that's confusing or unhelpful, let us know while we're still in beta and we can reconsider. |
No, I think that is sensible. It should give greater control if we have multiple audio variants of the same language which I assume is the intention. Thanks for clearing that up. I think it would be worth putting a note in the v2 migration guide about the difference in APIs in this respect from 1.x to 2. |
Actually, on some further reflection and discussion I want to present a possible problematic scenario. What happens if there are three audio tracks, all of them are english. Two of them are the same audio track with different bitrates but the third is the content audio plus directors commentary. How would we handle this situation? Selecting a specific track will turn off ABR which is not desirable if I want the player to handle switching bitrates between the first two tracks. But configuring the player for english tracks now is ambiguous because it doesn't allow us to specify if we want commentary or not. Update |
Makes sense. In a nutshell, we should allow selection by both role and language without disabling ABR. Is I'm tentatively scheduling this for v2+, but if we have a design sooner we can consider it for v2.0.0. |
Assuming that configure() is triggered immediately then I don't see any reason not to continue to use this approach. |
The current language switching via configure() is immediate, so the role switching could be as well. |
After further consideration, I think we should stop using Proposal:
@sanbornhnewyyz, thoughts? |
Add UI options to select current audio and text language. Split selectTrack() into selectText() and selectVariant(). Stop automatically disabling ABR manager when a variant is selected. Add a warning if selectVariant() is called while abr is enabled. Issue #412. Issue #626. Change-Id: I15f1c3c4fdc6d6b641f708fbef19dbcf10cbcfc6
Closing due to the fact that the new API has been implemented (and inactivity :)). |
I can see that there's a new API for selecting by audio language while keeping the ABR active, but I don't see how the role of the audio track is taken into account? How would a user enable a commentary track? |
Can you explain why abr gets disabled when selecting a different audio track? Most audio track switches are going to be for changing languages and I don't think this should interfere with abr for video tracks.
The text was updated successfully, but these errors were encountered: