Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the preferred language enables the text track visibility. #626

Closed
shanmugapriyaEK opened this issue Dec 9, 2016 · 2 comments
Closed

Setting the preferred language enables the text track visibility. #626

shanmugapriyaEK opened this issue Dec 9, 2016 · 2 comments
Assignees
@ismena
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@shanmugapriyaEK
Copy link

shanmugapriyaEK commented Dec 9, 2016 •
edited
Loading

  • What version of Shaka Player are you using?V2.0.1

    • Can you reproduce the issue with our latest release version?Yes
    • Can you reproduce the issue with the latest code from master?Yes

  • Are you using the demo app or your own custom app?

    • If custom app, can you reproduce the issue using our demo app?
      I could reproduce the issue in both custom and demo application.

  • What did you do?
    Try playing a multicodec and multilingual content

    • What content did you load?
      Angel one
      • If standard demo asset, which one?
        Angel one(multicodec and multilingual)
      • If custom asset, what manifest and license server URIs?
    • How did you interact with the content, if at all?
      Change the preferred text language. It enables the text track visibility

  • What did you expect to happen?
    Change the preferred text language should retain the state of the text T\track visibility

  • What actually happened?
    It enables the text track visibility by default

Scenario: In our application we had content that has three English audio track with different bit rates.
As we wanted to provide the user only the audio language access, we then used preferredAudioLanguage

But after using this, we found strange behavior which automatically switches text track. To fix this we determined the current active text track language and set it as preferred language. Now we could see that text track visibility is on when audio switches.

I could see that https://github.com/google/shaka-player/blob/master/lib/player.js at line number 1512
text track visibility is set to default value( showing) without retaining to the previous value.
@joeyparrish joeyparrish self-assigned this Dec 15, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Dec 15, 2016
@joeyparrish joeyparrish removed their assignment Dec 15, 2016
@joeyparrish
Copy link
Member

Thank you for the report. In a future release, we will only make text track visibility changes when explicitly requested instead of trying to enable it for you based on heuristics.

@joeyparrish joeyparrish added the flag: good first issue This might be a relatively easy issue; good for new contributors label Dec 15, 2016
@joeyparrish joeyparrish added this to the v2.1.0 milestone Jan 3, 2017
shaka-bot pushed a commit that referenced this issue Jan 18, 2017
@ismena
Make language selection explicit. Split text and variant selection.
23a23b9 
Add UI options to select current audio and text language.
Split selectTrack() into selectText() and selectVariant().
Stop automatically disabling ABR manager when a variant is selected.
Add a warning if selectVariant() is called while abr is enabled.

Issue #412.
Issue #626.

Change-Id: I15f1c3c4fdc6d6b641f708fbef19dbcf10cbcfc6
@ismena
Copy link
Contributor

ismena commented Jan 27, 2017

@shanmugapriyaEK we have recently changed the language selection API which seems to have taken care of this issue.
The code is in the latest master. Please feel free to reopen if you are still having problems.

@ismena ismena closed this as completed Jan 27, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
4 participants
@ismena @joeyparrish @shaka-bot @shanmugapriyaEK