Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.microsoft.playready to com.microsoft.playready.recommendation mapping in HLS #4243

Closed
wjywbs opened this issue May 18, 2022 · 2 comments · Fixed by #4254 or #4235
Closed

com.microsoft.playready to com.microsoft.playready.recommendation mapping in HLS #4243

wjywbs opened this issue May 18, 2022 · 2 comments · Fixed by #4254 or #4235
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@wjywbs
Copy link
Contributor

wjywbs commented May 18, 2022

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.
com.microsoft.playready.recommendation is recommended in #818 for Windows Edge. But HLS manifest uses com.microsoft.playready as key format, and shaka uses com.microsoft.playready CDM and license server config instead of com.microsoft.playready.recommendation

#EXT-X-KEY:METHOD=SAMPLE-AES,KEYFORMAT="com.microsoft.playready"
https://docs.microsoft.com/en-us/playready/packaging/mp4-based-formats-supported-by-playready-clients?tabs=case4

Describe the solution you'd like

{
  "drm": {
    "servers": {
      "com.microsoft.playready.recommendation": "https://url"
    }
  }
}

Shaka can provide a way to map the key format in HLS, and remain compatible with DASH.

Describe alternatives you've considered

Additional context

DASH playback supports key system mapping.
https://shaka-player-demo.appspot.com/docs/api/tutorial-drm-config.html#choosing-a-key-system

player.configure({
  dash: {
    keySystemsByURI: {
      'urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95': 'com.microsoft.playready.recommendation',
    }
  }
});
@wjywbs wjywbs added the type: enhancement New feature or request label May 18, 2022
@github-actions github-actions bot added this to the Backlog milestone May 18, 2022
@avelad avelad added the priority: P2 Smaller impact or easy workaround label May 18, 2022
@avelad
Copy link
Collaborator

avelad commented May 18, 2022

@wjywbs Are you interested in sending a PR for it?

@wjywbs
Copy link
Contributor Author

wjywbs commented May 18, 2022

I haven't checked how to fix this yet.

@avelad avelad self-assigned this May 24, 2022
@avelad avelad added the component: HLS The issue involves Apple's HLS manifest format label May 24, 2022
theodab pushed a commit that referenced this issue May 31, 2022
This allows, for example, users to use com.microsoft.playready.recommendation
instead of com.microsoft.playready.

Closes #4243
theodab pushed a commit to theodab/shaka-player that referenced this issue Jun 3, 2022
This allows, for example, users to use com.microsoft.playready.recommendation
instead of com.microsoft.playready.

Closes shaka-project#4243
@avelad avelad modified the milestones: Backlog, v4.1 Jun 5, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
gkatsev pushed a commit to sky-hugolima/shaka-player-contrib that referenced this issue Dec 22, 2023
…oject#249)

* feat: Add keySystemsMapping to drm config (shaka-project#4254)

This allows, for example, users to use com.microsoft.playready.recommendation
instead of com.microsoft.playready.

Closes shaka-project#4243

* feat: Allow add extra features to MediaSource.addSourceBuffer (shaka-project#4527)

* adjust configs, fix tests, revert some stuff

* fix: Fix drm.keySystemsMapping config (shaka-project#4425)

This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes shaka-project#4422

* Fix NO_LICENSE_URI_GIVEN error

* Revert "Fix NO_LICENSE_URI_GIVEN error"

This reverts commit 3aea08e2d4b10d185e8a8a6cf97ddb0944e07e86.

* deduplicate drminfos

* remove esvm workaround from MS Capabilities

* fix compilation

---------

Co-authored-by: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Co-authored-by: Viktor Vasylkovskyi <viktor.vasylkovskyi@sky.uk>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
2 participants