Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keySystemsMapping unrecognized #4422

Closed
sachaelkaim opened this issue Aug 17, 2022 · 3 comments · Fixed by #4425 or #4424
Closed

keySystemsMapping unrecognized #4422

sachaelkaim opened this issue Aug 17, 2022 · 3 comments · Fixed by #4425 or #4424
Assignees
Labels
component: EME The issue involves the Encrypted Media Extensions web API priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@sachaelkaim
Copy link
Contributor

sachaelkaim commented Aug 17, 2022

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?

4.2.0

Can you reproduce the issue with our latest release version?

yes

Can you reproduce the issue with the latest code from main?

yes

Are you using the demo app or your own custom app?

custom

If custom app, can you reproduce the issue using our demo app?

Have not tried

What browser and OS are you using?

macOS chrome
Windows Edge

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

tried to add keySystemsMapping to DRM config

player.configure({
  drm: {
    keySystemsMapping: {
      'com.microsoft.playready': 'com.microsoft.playready.recommendation',
    }
  }
});

What did you expect to happen?

To have the keysystemsmapping not be empty in my player.getconfiguration

What actually happened?

Getting a console response
Invalid config, unrecognized key .drm.keySystemsMapping.com.microsoft.playready

player.getconfiguration
preferredKeySystems":[],"keySystemsMapping":{}},

@sachaelkaim sachaelkaim added the type: bug Something isn't working correctly label Aug 17, 2022
@github-actions github-actions bot added this to the v4.3 milestone Aug 17, 2022
@joeyparrish joeyparrish added priority: P2 Smaller impact or easy workaround component: EME The issue involves the Encrypted Media Extensions web API labels Aug 18, 2022
@joeyparrish
Copy link
Member

That definitely seems wrong. We will look into it. Thanks!

@joeyparrish joeyparrish self-assigned this Aug 18, 2022
@joeyparrish
Copy link
Member

An override is missing from the config parser. Also, there are no tests covering that feature at all. I'll fix both.

@joeyparrish
Copy link
Member

This issue affects all v4.1 and v4.2 releases.

joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Aug 18, 2022
This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes shaka-project#4422
joeyparrish added a commit that referenced this issue Aug 18, 2022
This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes #4422
avelad pushed a commit that referenced this issue Aug 31, 2022
This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes #4422
avelad pushed a commit that referenced this issue Aug 31, 2022
This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes #4422
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
gkatsev pushed a commit to sky-hugolima/shaka-player-contrib that referenced this issue Dec 22, 2023
…oject#249)

* feat: Add keySystemsMapping to drm config (shaka-project#4254)

This allows, for example, users to use com.microsoft.playready.recommendation
instead of com.microsoft.playready.

Closes shaka-project#4243

* feat: Allow add extra features to MediaSource.addSourceBuffer (shaka-project#4527)

* adjust configs, fix tests, revert some stuff

* fix: Fix drm.keySystemsMapping config (shaka-project#4425)

This fixes the config by adding a missing override in the config parser.  This also adds test coverage for the feature.

Closes shaka-project#4422

* Fix NO_LICENSE_URI_GIVEN error

* Revert "Fix NO_LICENSE_URI_GIVEN error"

This reverts commit 3aea08e2d4b10d185e8a8a6cf97ddb0944e07e86.

* deduplicate drminfos

* remove esvm workaround from MS Capabilities

* fix compilation

---------

Co-authored-by: Álvaro Velad Galván <alvaro.velad@mirada.tv>
Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Co-authored-by: Viktor Vasylkovskyi <viktor.vasylkovskyi@sky.uk>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: EME The issue involves the Encrypted Media Extensions web API priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
2 participants