Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependency between offline.Storage and offline.DownloadManager #431

Closed
joeyparrish opened this issue Jun 30, 2016 · 0 comments
Closed

Circular dependency between offline.Storage and offline.DownloadManager #431

joeyparrish opened this issue Jun 30, 2016 · 0 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.0.0

Comments

@joeyparrish
Copy link
Member

In #421, Andy is trying to upgrade us to a newer compiler. That compiler caught this circular dependency as a missing goog.require.

offline.Storage requires offline.DownloadManager, but DownloadManager has this:

  var manifest = shaka.offline.Storage.getStoredContent(this.manifest_);
  this.config_.progressCallback(manifest, progress);

We should clean up this cycle.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jun 30, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone Jun 30, 2016
@joeyparrish joeyparrish mentioned this issue Jun 30, 2016
Merged
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot