fix: Simplify logging code for compatibility with webpack-terser-plugin #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some workarounds that were in the logging code for the sake of Internet Explorer. We no longer support IE, so those workarounds are no longer necessary. Issue shaka-project#5032
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
Mar 3, 2023
joeyparrish
changed the title
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Mar 7, 2023
…ceptions This reverts commit 6944976.
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Mar 7, 2023
PR shaka-project#5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
joeyparrish
added a commit
that referenced
this pull request
Mar 7, 2023
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This removes some workarounds that were in the logging code for the sake of Internet Explorer. We no longer support IE, so those workarounds are no longer necessary. Closes #5032
joeyparrish
added a commit
that referenced
this pull request
Apr 26, 2023
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This removes some workarounds that were in the logging code for the sake of Internet Explorer. We no longer support IE, so those workarounds are no longer necessary. Closes #5032
joeyparrish
added a commit
that referenced
this pull request
Apr 26, 2023
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some workarounds that were in the logging code for the sake of Internet Explorer. We no longer support IE, so those workarounds are no longer necessary.
Closes #5032