fix(Tizen): Fix exceptions thrown from logging methods #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR shaka-project#5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
|
Incremental code coverage: 50.00% |
|
Fix verified on Tizen. PTAL! |
avelad
approved these changes
Mar 7, 2023
avelad
added
type: bug
littlespex
approved these changes
Mar 7, 2023
joeyparrish
added a commit
that referenced
this pull request
Apr 26, 2023
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
joeyparrish
added a commit
that referenced
this pull request
Apr 26, 2023
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released. This fixes the issue by using arrow functions to prevent unboxing.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5050 unboxed the console log methods, which broke logging on Tizen. This change was never released.
This fixes the issue by using arrow functions to prevent unboxing.
BEGIN_COMMIT_OVERRIDE
chore: Fix exceptions thrown from logging methods
Ignored in changelog because the bug this fixes was never released.
END_COMMIT_OVERRIDE