Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Fix bad error on DASH DAI #6047

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix(DASH): Fix bad error on DASH DAI #6047

merged 1 commit into from
Jan 9, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 8, 2024

Fixes #6010

@avelad
Copy link
Member Author

avelad commented Jan 8, 2024

@theodab the regression was introduced in 24e3255

Review with the asset Tears of Steel (live, DASH, Server Side ads)

@avelad avelad requested a review from theodab January 8, 2024 13:49
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Jan 8, 2024
@avelad avelad added this to the v5.0 milestone Jan 8, 2024
@avelad avelad merged commit a371f43 into shaka-project:main Jan 9, 2024
15 of 19 checks passed
@avelad avelad deleted the dai-fix branch January 9, 2024 07:48
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
avelad added a commit that referenced this pull request Jan 9, 2024
@avelad
fix(DASH): Fix bad error on DASH DAI (#6047)
ce8792d 
Fixes #6010
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

DASH + ad insertion: Uncaught exception in promise in 4.7.0
3 participants
@avelad @theodab @shaka-bot