Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Demo): Show APIC(ID3) as poster for audio only streams #6122

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat(Demo): Show APIC(ID3) as poster for audio only streams #6122

merged 1 commit into from
Jan 19, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 18, 2024

No description provided.

@avelad
Copy link
Member Author

avelad commented Jan 18, 2024

Test stream https://stream-cdn-1.open.fm/OFM18/ngrp:standard/playlist.m3u8

@avelad avelad added type: enhancement New feature or request component: demo page The issue is in the demo page; does not affect production applications priority: P4 Nice to have / wishful thinking labels Jan 18, 2024
@avelad avelad added this to the v5.0 milestone Jan 18, 2024
@avelad avelad changed the title feat(Demo): Show APIC (ID3)as poster for audio only streams feat(Demo): Show APIC(ID3) as poster for audio only streams Jan 18, 2024
@avelad avelad merged commit 291b497 into shaka-project:main Jan 19, 2024
17 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 19, 2024
Merged
@avelad avelad deleted the apic-demo branch January 19, 2024 07:51
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @theodab @shaka-bot