Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add config to set live stream duration to Infinity #6207

Merged
merged 2 commits into from
Feb 20, 2024
Merged

feat: Add config to set live stream duration to Infinity #6207

merged 2 commits into from
Feb 20, 2024

Conversation

Vasanthavanan-Devarajan
Copy link
Contributor

@Vasanthavanan-Devarajan Vasanthavanan-Devarajan commented Jan 31, 2024 •
edited by avelad
Loading

Fixes: #6205

@Vasanthavanan-Devarajan Vasanthavanan-Devarajan mentioned this pull request Jan 31, 2024
Closed
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Feb 1, 2024
@avelad avelad added this to the v5.0 milestone Feb 1, 2024
joeyparrish
joeyparrish requested changes Feb 1, 2024
View reviewed changes
demo/config.js Outdated Show resolved Hide resolved
externs/shaka/player.js Outdated Show resolved Hide resolved
@joeyparrish joeyparrish changed the title fix: Allow Media Source Live Duration as Infinity feat: Add config to set live stream duration to Infinity Feb 1, 2024
@avelad avelad added type: enhancement New feature or request and removed type: bug Something isn't working correctly labels Feb 1, 2024
@joeyparrish
Copy link
Member

Your rebase attempt seems to have broken things. There are many conflicts now.

@Vasanthavanan-Devarajan
Copy link
Contributor Author

Your rebase attempt seems to have broken things. There are many conflicts now.

let me revert back and fix

@joeyparrish joeyparrish merged commit de2957e into shaka-project:main Feb 20, 2024
12 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Feb 20, 2024
Merged
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@avelad avelad Awaiting requested review from avelad

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

[SHAW X1] - DOES NOT SUPPORT MEDIA SOURCE DURATION as a FINITE NUMBER
4 participants
@Vasanthavanan-Devarajan @joeyparrish @shaka-bot @avelad