Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPD parser incorrectly refuses Periods without duration attribute #9

Closed
barbibulle opened this issue Jan 12, 2015 · 4 comments
Closed
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@barbibulle
Copy link

The MPD parser insists on finding an @duration attribute for a Period when the SegmentTemplate has a segment duration.
For simple static MPDs with only one Period element, the Period@duration attribute is optional. The Period duration can be inferred from the MPD@mediaPresentationDuration attribute

The DASH spec, section 5.3.2.1 indicates:
"...The Period extends until the PeriodStart of the next Period, or until the end of the Media Presentation in the case of the last Period..."

The shaka code that throws the error is:
mpd_processor.js, line 555
shaka.log.error(
'SegmentTemplate provides a segment duration but the ' +
'Period's duration is unknown.');

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 12, 2015
@joeyparrish joeyparrish self-assigned this Jan 12, 2015
@joeyparrish joeyparrish added this to the v1.1 milestone Jan 12, 2015
@joeyparrish
Copy link
Member

Thanks for the report. Can you please send a sample MPD which exhibits this behavior?

@joeyparrish
Copy link
Member

Actually, never mind the MPD. I found the issue.

The bug is in mpd_processor.js, in process(). The order of calculateDurations_() and processSegmentTemplates_() needs to be swapped. Sorry for the inconvenience.

We'll push this fix out shortly in v1.1.

@barbibulle
Copy link
Author

Thanks!

-- Gilles

On January 12, 2015 at 12:54:02 PM, joeyparrish (notifications@github.com) wrote:

Actually, never mind the MPD. I found the issue.

The bug is in mpd_processor.js, in process(). The order of calculateDurations_() and processSegmentTemplates_() needs to be swapped. Sorry for the inconvenience.

We'll push this fix out shortly in v1.1.


Reply to this email directly or view it on GitHub.

@joeyparrish
Copy link
Member

v1.1 is out now. The fix was slightly more complicated than I originally thought, though, so you may want to update.

Also, we now have a user mailing list where you can ask questions and receive notifications of new releases. https://groups.google.com/forum/#!forum/shaka-player-users

Thanks again for the bug report!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants