build: Upgrade CSS linter #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version requires additional configuration for less syntax, and has new default rules we were out of compliance with. I disabled rules about avoiding explicit vendor prefixes (such as "-webkit") because we are not using any auto-prefixer tools. Other violations have been fixed: - kebab-case for element ids - quotes around URLs - double quotes instead of single quotes - disable class selector pattern matching for MDL (external) - use modern rgb/rgba syntax - no quotes on font families - no long-hand when short-hand will do This brings our NPM audit vulnerabilities from 20 down to 10.
joeyparrish
added
the
component: build system
theodab
approved these changes
Feb 22, 2022
This was referenced Mar 15, 2022
joeyparrish
added a commit
that referenced
this pull request
Mar 15, 2022
In #3991, I changed the syntax of our colors to a modern rgba syntax. For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 / 85%). However, less v3 seems not to understand that properly, and performs division on the last two parts, resulting in output of rgba(255 255 3%), which is indeed invalid. This fixes the issue by upgrading to less v4, which understands the new rgba syntax and leaves it alone. The output for that will now match the input. To work around an issue with less v4, this uses a prerelease version with a fix for less/less.js#3693 . See also tomas/needle#391 This doesn't affect any release branches, since #3991 hasn't been cherry-picked. Closes #4027
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
The new version requires additional configuration for less syntax, and has new default rules we were out of compliance with. I disabled rules about avoiding explicit vendor prefixes (such as "-webkit") because we are not using any auto-prefixer tools. Other violations have been fixed: - kebab-case for element ids - quotes around URLs - double quotes instead of single quotes - disable class selector pattern matching for MDL (external) - use modern rgb/rgba syntax - no quotes on font families - no long-hand when short-hand will do
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
The new version requires additional configuration for less syntax, and has new default rules we were out of compliance with. I disabled rules about avoiding explicit vendor prefixes (such as "-webkit") because we are not using any auto-prefixer tools. Other violations have been fixed: - kebab-case for element ids - quotes around URLs - double quotes instead of single quotes - disable class selector pattern matching for MDL (external) - use modern rgb/rgba syntax - no quotes on font families - no long-hand when short-hand will do
joeyparrish
added a commit
that referenced
this pull request
Apr 21, 2022
The new version requires additional configuration for less syntax, and has new default rules we were out of compliance with. I disabled rules about avoiding explicit vendor prefixes (such as "-webkit") because we are not using any auto-prefixer tools. Other violations have been fixed: - kebab-case for element ids - quotes around URLs - double quotes instead of single quotes - disable class selector pattern matching for MDL (external) - use modern rgb/rgba syntax - no quotes on font families - no long-hand when short-hand will do
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version requires additional configuration for less syntax, and
has new default rules we were out of compliance with.
I disabled rules about avoiding explicit vendor prefixes (such as
"-webkit") because we are not using any auto-prefixer tools. Other
violations have been fixed:
This brings our NPM audit vulnerabilities from 20 down to 10.