-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECONNRESET thrown after connection closed #391
Comments
joeyparrish
added a commit
to joeyparrish/needle
that referenced
this issue
Mar 15, 2022
This was referenced Mar 15, 2022
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this issue
Mar 15, 2022
In #3991, I changed the syntax of our colors to a modern rgba syntax. For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 / 85%). However, less v3 seems not to understand that properly, and performs division on the last two parts, resulting in output of rgba(255 255 3%), which is indeed invalid. This fixes the issue by upgrading to less v4, which understands the new rgba syntax and leaves it alone. The output for that will now match the input. To work around an issue with less v4, this uses a prerelease version with a fix for less/less.js#3693 . See also tomas/needle#391 This doesn't affect any release branches, since #3991 hasn't been cherry-picked. Closes #4027
However, I am not sure if this is the correct approach here. Maybe the error listener should be removed AFTER the socket has been destroyed instead of explicitly aborting/destroying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
less v4 uses needle for https requests. It fails with ECONNRESET on macOS specifically, which is reproducible in GitHub Actions as well as on our private mac hardware. The failure is caused by an
ECONNRESET
error after the connection is closed.Details can be found here:
The node discussion includes a workaround, which is that you can call abort() explicitly after closing the connection. I will send a PR with that fix shortly.
The text was updated successfully, but these errors were encountered: