Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECONNRESET thrown after connection closed #391

Closed
joeyparrish opened this issue Mar 15, 2022 · 1 comment · Fixed by #392
Closed

ECONNRESET thrown after connection closed #391

joeyparrish opened this issue Mar 15, 2022 · 1 comment · Fixed by #392

Comments

@joeyparrish
Copy link
Contributor

less v4 uses needle for https requests. It fails with ECONNRESET on macOS specifically, which is reproducible in GitHub Actions as well as on our private mac hardware. The failure is caused by an ECONNRESET error after the connection is closed.

Details can be found here:

The node discussion includes a workaround, which is that you can call abort() explicitly after closing the connection. I will send a PR with that fix shortly.
@joeyparrish joeyparrish mentioned this issue Mar 15, 2022
Closed
joeyparrish added a commit to joeyparrish/needle that referenced this issue Mar 15, 2022
@joeyparrish
fix: Silence ECONNRESET errors after connection close
86b2c2f 
See also less/less.js#3693

Fixes tomas#391
This was referenced Mar 15, 2022
Merged
Merged
joeyparrish added a commit to shaka-project/shaka-player that referenced this issue Mar 15, 2022
@joeyparrish
chore(deps): Upgrade less to v4 (prerelease) (#4028)
f5f5177 
In #3991, I changed the syntax of our colors to a modern rgba syntax.
For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 /
85%). However, less v3 seems not to understand that properly, and
performs division on the last two parts, resulting in output of
rgba(255 255 3%), which is indeed invalid.

This fixes the issue by upgrading to less v4, which understands the
new rgba syntax and leaves it alone. The output for that will now
match the input.

To work around an issue with less v4, this uses a prerelease version
with a fix for less/less.js#3693 . See also
tomas/needle#391

This doesn't affect any release branches, since #3991 hasn't been
cherry-picked.

Closes #4027
@alolis
Copy link

alolis commented Apr 13, 2022 •
edited

abort is deprecated since node.js v13.14.0 as per the documentation here. destroy should be used instead.

However, I am not sure if this is the correct approach here. Maybe the error listener should be removed AFTER the socket has been destroyed instead of explicitly aborting/destroying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Silence ECONNRESET errors after connection close joeyparrish/needle
2 participants
@alolis @joeyparrish