chore(deps): Upgrade less to v4 (prerelease) #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodab
previously approved these changes
Mar 15, 2022
|
Shoot, now I remember why we weren't already on less v4. It's failing on macOS. I even filed less/less.js#3693 |
joeyparrish
changed the title
theodab
previously approved these changes
Mar 15, 2022
In #3991, I changed the syntax of our colors to a modern rgba syntax. For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 / 85%). However, less v3 seems not to understand that properly, and performs division on the last two parts, resulting in output of rgba(255 255 3%), which is indeed invalid. This fixes the issue by upgrading to less v4, which understands the new rgba syntax and leaves it alone. The output for that will now match the input. To work around an issue with less v4, this uses a prerelease version with a fix for less/less.js#3693 . See also tomas/needle#391 This doesn't affect any release branches, since #3991 hasn't been cherry-picked. Closes #4027
|
It turns out that my forked prerelease of less.js needed some generated code checked in to be usable in this way. So I had to update the sha1 again. |
|
And this time, I actually fully tested the package.json locally in shaka-player. :-) |
theodab
approved these changes
Mar 15, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3991, I changed the syntax of our colors to a modern rgba syntax.
For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 /
85%). However, less v3 seems not to understand that properly, and
performs division on the last two parts, resulting in output of
rgba(255 255 3%), which is indeed invalid.
This fixes the issue by upgrading to less v4, which understands the
new rgba syntax and leaves it alone. The output for that will now
match the input.
To work around an issue with less v4, this uses a prerelease version
with a fix for less/less.js#3693 . See also
tomas/needle#391
This doesn't affect any release branches, since #3991 hasn't been
cherry-picked.
Closes #4027