Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade less to v4 (prerelease) #4028

Merged
merged 1 commit into from
Mar 15, 2022
Merged

chore(deps): Upgrade less to v4 (prerelease) #4028

merged 1 commit into from
Mar 15, 2022

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Mar 15, 2022

In #3991, I changed the syntax of our colors to a modern rgba syntax.
For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 /
85%). However, less v3 seems not to understand that properly, and
performs division on the last two parts, resulting in output of
rgba(255 255 3%), which is indeed invalid.

This fixes the issue by upgrading to less v4, which understands the
new rgba syntax and leaves it alone. The output for that will now
match the input.

To work around an issue with less v4, this uses a prerelease version
with a fix for less/less.js#3693 . See also
tomas/needle#391

This doesn't affect any release branches, since #3991 hasn't been
cherry-picked.

Closes #4027

theodab
theodab previously approved these changes Mar 15, 2022
@joeyparrish
Copy link
Member Author

Shoot, now I remember why we weren't already on less v4. It's failing on macOS. I even filed less/less.js#3693

@joeyparrish joeyparrish changed the title chore(deps): Upgrade less to v4 chore(deps): Upgrade less to v4 (prerelease) Mar 15, 2022
theodab
theodab previously approved these changes Mar 15, 2022
In #3991, I changed the syntax of our colors to a modern rgba syntax.
For example, rgba(255, 255, 255, 0.85) would become rgba(255 255 255 /
85%). However, less v3 seems not to understand that properly, and
performs division on the last two parts, resulting in output of
rgba(255 255 3%), which is indeed invalid.

This fixes the issue by upgrading to less v4, which understands the
new rgba syntax and leaves it alone. The output for that will now
match the input.

To work around an issue with less v4, this uses a prerelease version
with a fix for less/less.js#3693 . See also
tomas/needle#391

This doesn't affect any release branches, since #3991 hasn't been
cherry-picked.

Closes #4027
@joeyparrish
Copy link
Member Author

It turns out that my forked prerelease of less.js needed some generated code checked in to be usable in this way. So I had to update the sha1 again.

@joeyparrish
Copy link
Member Author

And this time, I actually fully tested the package.json locally in shaka-player. :-)

@joeyparrish joeyparrish merged commit f5f5177 into shaka-project:main Mar 15, 2022
@joeyparrish joeyparrish deleted the css-color-fix branch March 15, 2022 21:53
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background colors broken in CSS generated by Less v3
2 participants