Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type entry in package.json #419

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

ahangarha
Copy link
Member

@ahangarha ahangarha commented Mar 4, 2023

Summary

This PR reverts the bug introduced in #416. Having type entry in package.json file causes malfunctions in this package.

Pull Request checklist

  • Add/update test to cover these changes (not needed)
  • Update documentation (not needed)
  • Update CHANGELOG file

Other Information

We need to have a test to cover such situation.


This change is Reviewable

@ahangarha ahangarha requested a review from justin808 March 4, 2023 12:37
@justin808 justin808 merged commit 568a5f2 into master Mar 7, 2023
@justin808 justin808 deleted the fix-bug-related-to-type-entry-in-package-json branch March 7, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants