-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bootstrap 4 #38
Conversation
@@ -3,62 +3,61 @@ module.exports = { | |||
styleLoader: 'style-loader!css-loader!sass-loader', | |||
|
|||
scripts: { | |||
'transition': true, | |||
'util': true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need different manifest files for Bootstrap 3 and Bootstrap 4
@alexfedoseev Please double check we're putting files in the right order. Also, please add some comments on the difference between the "main" sass file as well as the "bootstrap-customization file". While you could put all post-bootstrap loading customizations in the bootstrap-customization file, you separate out that to a second sass file which is your own app's sass files. Your app's sass files will be able to any sass variables defined by bootstrap. CC: @robwise |
Any idea on when this will be ready to go? |
@maxbates It's just about ready. We could definitely use some help with testing and documentation. |
Closing as we're about to put in the PR that will take this loader to the next level. See it in action here: shakacode/react-webpack-rails-tutorial#175 |
No description provided.