Babel 6 / CSS Modules / Rails hot reloading #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex35mil
force-pushed
the
alex/client-babel-6-css-modules-rails-hot
branch
from
5e46c27
to
c088fc4
Compare
|
@alexfedoseev I'll start reviewing. |
|
|
||
| // Next two depend on jQuery | ||
| // This one depend on jQuery |
|
@alexfedoseev 👏 👏 👏 FABULOUS!!! As soon as CI tests pass, let's merge. @robwise there's a couple testing to-do's in the PR. |
| @@ -1,2 +1,11 @@ | |||
| module ApplicationHelper | |||
| def javascript_include_env_tag(asset, dev_asset, params = {}) | |||
There was a problem hiding this comment.
This name is too close to the default rails one javascript_include_tag and thus easy to miss.
I'd suggest env_specific_javascript_include_tag and env_specific_stylesheet_link_tag.
This was referenced Dec 12, 2015
| @import 'app-bundle'; | ||
|
|
||
| // Non-webpack assets | ||
| @import 'application_dev'; |
There was a problem hiding this comment.
Where is this partial located?
There was a problem hiding this comment.
Right next to current file.
justin808
force-pushed
the
alex/client-babel-6-css-modules-rails-hot
branch
from
4c9ff07
to
410bac6
Compare
| "babel-preset-stage-0": "^6.3.13", | ||
| "bootstrap-loader": "^1.0.0-rc", | ||
| "bootstrap-sass": "^3.3.5", | ||
| "css-loader": "^0.23.0", | ||
| "es5-shim": "^4.3.1", | ||
| "es6-promise": "^3.0.2", |
There was a problem hiding this comment.
Isn't this redundant given babel-polyfill?
Configured testing so that:
* If we're not running a webpack process to watch the client JS files,
then we build the client or server files.
* Test will let you know if it's skipping building.
Expression used to see if a watch process is running:
`pgrep -fl '\\-w \\-\\-config webpack\\.#{type}\\.rails\\.build\\.config\\.js'`
* Renamed asset helpers so usage is like this:
<%= env_stylesheet_link_tag 'application_prod', 'application_dev', media: 'all', 'data-turbolinks-track' => true %>
<%= env_javascript_include_tag nil, 'http://localhost:3500/vendor-bundle.js' %>
<%= env_javascript_include_tag nil, 'http://localhost:3500/app-bundle.js' %>
<%= env_javascript_include_tag 'application_prod', 'application_dev', 'data-turbolinks-track' => true %>
TODO: Should we consider having tests use the Rails hot reload server?
Remove building bundles from install script
Since the new spec configuration does it.
Fix scss linter errors
Had to turn off SelectorFormat since css modules require JS style names.
Fix typo
alex35mil
force-pushed
the
alex/client-babel-6-css-modules-rails-hot
branch
from
583ba35
to
16e770c
Compare
alex35mil
added a commit
that referenced
this pull request
Dec 13, 2015
…s-rails-hot Babel 6 / CSS Modules / Rails hot reloading
|
Merged. |
|
👍 🎆 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstrap-loader&sass-resources-loader/cc: @justin808 @robwise @yorzi