Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Possible No-op] Adjust Procfiles for compatibility with both foreman and forego #310

Closed
wants to merge 1 commit into from
Closed

[Possible No-op] Adjust Procfiles for compatibility with both foreman and forego #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Procfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
rails: REACT_ON_RAILS_ENV=HOT rails s -b 0.0.0.0

# Run the hot reload server for client development
hot-assets: sh -c 'rm app/assets/webpack/* || true && HOT_RAILS_PORT=3500 npm run hot-assets'
hot_assets: sh -c 'rm app/assets/webpack/* || true && HOT_RAILS_PORT=3500 npm run hot-assets'

# Render static client assets
rails-static-client-assets: sh -c 'npm run build:dev:client'
rails_static_client_assets: sh -c 'npm run build:dev:client'

# Render static client assets. Remove if not server rendering
rails-static-server-assets: sh -c 'npm run build:dev:server'
rails_static_server_assets: sh -c 'npm run build:dev:server'

# Run an express server if you want to mock out your endpoints. No Rails involved!
# Disable this if you are not using it.
Expand Down
4 changes: 2 additions & 2 deletions Procfile.hot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
rails: REACT_ON_RAILS_ENV=HOT rails s -b 0.0.0.0

# Run the hot reload server for client development
hot-assets: sh -c 'rm app/assets/webpack/* || true && HOT_RAILS_PORT=3500 npm run hot-assets'
hot_assets: sh -c 'rm app/assets/webpack/* || true && HOT_RAILS_PORT=3500 npm run hot-assets'

# Keep the JS fresh for server rendering. Remove if not server rendering
rails-server-assets: sh -c 'npm run build:dev:server'
rails_server_assets: sh -c 'npm run build:dev:server'
4 changes: 2 additions & 2 deletions Procfile.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# in rails_helper.rb.

# Build client assets, watching for changes.
rails-client-assets: sh -c 'npm run build:dev:client'
rails_client_assets: sh -c 'npm run build:dev:client'

# Build server assets, watching for changes. Remove if not server rendering.
rails-server-assets: sh -c 'npm run build:dev:server'
rails_server_assets: sh -c 'npm run build:dev:server'
4 changes: 2 additions & 2 deletions Procfile.static
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
rails: REACT_ON_RAILS_ENV= rails s -b 0.0.0.0

# Build client assets, watching for changes.
rails-client-assets: rm app/assets/webpack/* || true && npm run build:dev:client
rails_client_assets: rm app/assets/webpack/* || true && npm run build:dev:client

# Build server assets, watching for changes. Remove if not server rendering.
rails-server-assets: npm run build:dev:server
rails_server_assets: npm run build:dev:server
4 changes: 2 additions & 2 deletions Procfile.static.trace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
rails: TRACE_REACT_ON_RAILS=TRUE rails s -b 0.0.0.0

# Build client assets, watching for changes.
rails-client-assets: npm run build:dev:client
rails_client_assets: npm run build:dev:client

# Build server assets, watching for changes. Remove if not server rendering.
rails-server-assets: npm run build:dev:server
rails_server_assets: npm run build:dev:server