Generator raises error when application.js is not found

[rupurt]

We currently have our application split up into multiple smaller applications so don't use the main application.js file. It would nice if the generator allowed you to specify the name of the manifest file e.g.

rails generate react_on_rails:install -m my_cool_app

[justin808]

@rupurt As a workaround, just create an empty file right now.

If you could submit a PR for your enhancement, we'd take it!

[rupurt]

@justin808 that's what I did 😄

I'll see if I have some time to take a stab at it over the weekend.

[robwise]

@rupurt That would be awesome! Definitely take a look at the lib/generators/react_on_rails/base_generator.rb file, as I believe this may be the right place for this logic. We could also try putting this logic inside of the config/initializers/react_on_rails.rb initializer, although I'm not sure if that work and/or maybe that's not a solution for your specific scenario.

[yorzi]

Generator raises error when application.css.scss is not found as well (in our case we use application.scss), I think it's a similar issue. It might be good to be able to config these files in initializer.

[robwise]

@yorzi I would say this issue is an enhancement, whereas yours is closer to a bug. I have therefore made a separate issue: #86

[yorzi]

@robwise 👍 I can look into that today.

[justin808]

@yorzi Would be awesome if you can submit a PR to fix the missing files!

[justin808]

@robwise Can we close this one?

[robwise]

@justin808 negative, I fixed a different issue that was with the application.scss, not js. This issue will still occur. I can come up with a fix if you want.

1. We can allow passing an argument to specify a different file than application.js
2. We can simply create an application.js file if it is missing

The latter solution would not actually really fix @rupurt's problem, though, but it would at least let the generator run through completion by default instead of essentially forcing him to figure out that he needs to make his own application.js file, run the generator, and then move the code manually to where he wants it.

[justin808]

@robwise I vote for 2) with a warning as the user will see the diff and can take appropriate action.