Have generator create application.js file if not found #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwise
force-pushed
the
application-js-fix
branch
from
a0708de
to
cbb5717
Compare
| else | ||
| puts_setup_file_error("#{application_js} or #{application_js}.coffee", data) | ||
| create_file(app_js_path, data << "\n\n//= require turbolinks\n\n") |
There was a problem hiding this comment.
Why add turbolinks? It's not a requirement of react_on_rails. We support it, but don't necessarily encourage it.
I'd say remove this.
There was a problem hiding this comment.
@justin808 roger that, makes sense
robwise
force-pushed
the
application-js-fix
branch
from
cbb5717
to
d8b491a
Compare
|
@justin808 this should be good to go pending a final review |
|
@robwise This looks fine so long as it's well tested. Let me know and I'll merge. |
|
@justin808 yep, the important part of the associated test is here: https://github.com/shakacode/react_on_rails/pull/108/files#diff-dd34ce0d9a02be7e957b081e5d11cb7cR146 since it doesn't create an existing application.js like it usually does, and yet the file still shows up as expected as running the generator. |
robwise
force-pushed
the
application-js-fix
branch
2 times, most recently
from
a21916d
to
c6d122e
Compare
Fixes #78 Generator used to put a setup error message when it did not find application.js. Now, it will simply just create one with the necessary data in it. Note that we don't generate a turbolinks sprockets requirement if we create the file for the user since this is not really related to implementing React on Rails. Users should add this manually if they want turbolinks.
robwise
force-pushed
the
application-js-fix
branch
from
c6d122e
to
f8999d0
Compare
robwise
added a commit
that referenced
this pull request
Nov 23, 2015
Have generator create application.js file if not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Generator used to put a setup error message when it did not find
application.js. Now, it will simply just create one with the
necessary data in it.