Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bs-webapi with rescript-webapi? #26

Closed
SamWoolerton opened this issue Jun 9, 2021 · 3 comments
Closed

Replace bs-webapi with rescript-webapi? #26

SamWoolerton opened this issue Jun 9, 2021 · 3 comments

Comments

@SamWoolerton
Copy link

Looks like bs-webapi hasn't been touched in a year, whereas rescript-webapi is under active development (I'm not affiliated with either). If the bindings are the same but just updated, then might be good to update this.

Would also be great to add a note to Readme to go install that package too (not sure if it's obvious for others but I'm new to Rescript and was a bit surprised).

@alex35mil
Copy link
Member

Thanks for bringing this up! Yeah, we should probably do it. I will check out rescript-webapi sometime.

@darenju
Copy link

darenju commented Nov 16, 2021

Would also be great to add a note to Readme to go install that package too (not sure if it's obvious for others but I'm new to Rescript and was a bit surprised).

Bumping this. Needed to re-build -with-deps to notice I had to install bs-webapi and add it in bs-dependencies :)

darenju added a commit to darenju/rescript-dnd that referenced this issue Nov 16, 2021
Related to shakacode#26. Had no idea this was needed before building freshly.
@alex35mil
Copy link
Member

Fixed in #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants