Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset_pack_path example #65

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Fix asset_pack_path example #65

merged 1 commit into from
Feb 20, 2022

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Feb 17, 2022

I found that the supplied example doesn't work with 6.1.1, as the manifest has static files at static/ instead of images/.

tomdracz
tomdracz approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@tomdracz tomdracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Technically you need neither images/ or static/ in the path given to a helper - it gets appended automatically!

@justin808 justin808 merged commit 67d6a87 into shakacode:master Feb 20, 2022
@justin808
Copy link
Member

Thanks @swrobel

2 similar comments
@justin808
Copy link
Member

Thanks @swrobel

@justin808
Copy link
Member

Thanks @swrobel

@swrobel
Copy link
Contributor Author

swrobel commented Feb 20, 2022

Thanks @swrobel

🤙🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdracz tomdracz tomdracz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swrobel @justin808 @tomdracz