Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify numeric columns #58

Closed
victor-luu191 opened this issue Jun 29, 2020 · 1 comment · Fixed by #57
Closed

identify numeric columns #58

victor-luu191 opened this issue Jun 29, 2020 · 1 comment · Fixed by #57
Labels
enhancement New feature or request

Comments

@victor-luu191
Copy link
Contributor

Describe the new feature:

This is useful to gather all numeric columns into a list so that later we can apply any transformation on them in one-liner style. For example, fill NAs in the numeric columns by their means.

What is the current outcome?

Module nominal already has method identify_nominal_columns to find nominal columns. I follow its style and added to my fork a method identify_numeric_columns, but it seems I cannot make a pull request yet because there is another request pending. Can @shakedzy accept my previous pull request?

Is it backward-compatible?

Should be no problem, as it is independent from others.

@victor-luu191 victor-luu191 added the enhancement New feature or request label Jun 29, 2020
@shakedzy shakedzy linked a pull request Jun 30, 2020 that will close this issue
@shakedzy
Copy link
Owner

Nice idea, both this one and the missing values. I've add a new method, identify_columns_by_type which is more general, and now identify_nominal_columns and identify_numeric_columns are shortcuts to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants