Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Tween._done be a list? #43

Closed
tianzhuqiao opened this issue Jan 29, 2020 · 2 comments · Fixed by #44
Closed

Should Tween._done be a list? #43

tianzhuqiao opened this issue Jan 29, 2020 · 2 comments · Fixed by #44

Comments

@tianzhuqiao
Copy link

Thanks for the great project, @shakiba. Currently Tween._done supports one function. Should we make it a list, such that the following application will also work?
img.tween(100).alpha(0).remove().done(fn)

Otherwise, it will fail to remove since

  1. remove() set _done to this.remove(),
  2. but done(fn) will overwrite the _done. to fn.
@shakiba
Copy link
Collaborator

shakiba commented Jan 30, 2020

Hmm, yes that doesn't look good. I'm not sure if we should queue or replace multiple "done", but remove and done should be separated. Would you be able to make a PR to fix it?

@tianzhuqiao
Copy link
Author

Yeah, separate remove() and hide() from done() is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants