Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a standard debug logging class that isn't console.writeline #63

Open
3 tasks
noita-player opened this issue May 9, 2022 · 2 comments
Open
3 tasks

Comments

@noita-player
Copy link
Contributor

noita-player commented May 9, 2022

Problems:

  • Needs to support: output to stdout, out to file, and both at the same time. Electronbridge might need stdout. ElectronBridge launch parameter support #62
  • Different debug levels, ideally, such as error vs info - so we can have an info-log that is very small output and always there, then enable the debug flag and have it dump debug-level messages too that might be more spew-ey
  • Can we get line numbers for exceptions in release builds? Maybe if the logger is passed an exception object? Do we need to ship full PDBs?
@shalzuth
Copy link
Owner

shalzuth commented May 9, 2022

I agree, but having a dependency on not using stdout isn't acceptable.
PDB is required for line numbers, i can include that in the artifacts (but user will need to download it in addition to the exe)

@shalzuth
Copy link
Owner

shalzuth commented May 9, 2022

Logger class could prevent stdout from normal log calls for electronbridge as a temporary means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants