Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default version for generated package.json is always '0.0.0' #78

Open
ZaDarkSide opened this issue Mar 29, 2017 · 1 comment
Open

Default version for generated package.json is always '0.0.0' #78

ZaDarkSide opened this issue Mar 29, 2017 · 1 comment

Comments

@ZaDarkSide
Copy link

ZaDarkSide commented Mar 29, 2017

The default version for generated package.json is defined in file lib/pkg.js:

    pkg = {
      name: this.name,
      version: '0.0.0', // here is the default version
      description: '-',
      repository: {type: 'git', url: '-'},
      readme: '-'
    }

has version: '0.0.0'

It should read the version from the tag/release I have chosen in my package.json:

...
  "scripts": {
    "install": "napa"
  },
  "napa": {
    "datatables.net-plugins": "DataTables/Plugins#1.10.13" // should take version 1.10.13 from here
  }
...
@Grawl
Copy link
Contributor

Grawl commented Aug 18, 2017

It's a complex problem because napa can download just anything and make a package out of it. I think we should not parse URL and add separate version field instead. Like this:

{
  "napa": {
    "datatables.net-plugins": {
      "url": "DataTables/Plugins#1.10.13",
      "version": "1.10.13"
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants