Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split _CborListImpl into _CborDefiniteLengthListImpl and _CborIndefiniteLengthListImpl #51

Closed
AlexDochioiu opened this issue Apr 11, 2023 · 3 comments

Comments

@AlexDochioiu
Copy link
Contributor

Hello,

I would like to add an option to explicitly define definite/indefinite list length and also to maintain this context when parsing CBOR.

Context: I am performing cryptographic operations and hashing on CBOR data. The fact that HexEncodedCbor -> CborValue -> HexEncodedCbor yields a different result compared to the input is causing me problems and making stuff harder to test. Also I often need to make additive changes to CBOR. But doing this and re-encoding the CBOR turns some indefinite lists into a definite lists.

P.S. I am happy to help with this work. I just wanted to know whether you would accept merging a PR for it. Otherwise I'd just fork this and maintain a separate copy myself.

@shamblett
Copy link
Owner

Hi, yes I will look at any PR's for this you might want to raise, sorry for the late reply here.

@shamblett
Copy link
Owner

Complete, package re published at version 6.1.0

@AlexDochioiu
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants