Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numeric value for media_content_id #114

Closed
benjaminandrews38 opened this issue Jan 3, 2024 · 2 comments
Closed

Allow numeric value for media_content_id #114

benjaminandrews38 opened this issue Jan 3, 2024 · 2 comments

Comments

@benjaminandrews38
Copy link

benjaminandrews38 commented Jan 3, 2024

Is your feature request related to a problem? Please describe.
media_player.play_media only accepts a string value for media_content_id. Some smart TV integrations allow channel selection by integer value. This is supported by home assistant.

Describe the solution you'd like
It would be nice if the type was string|number, and I hope this isn't too onerous

Describe alternatives you've considered
I'm not sure of any alternative solutions

Additional context
I'm trying to create a tv remote component with an integrated program guide. So far in testing, only an LG webOS tv has worked with string channel values.

It works fine using useStore().connection.sendMessage, so not a huge priority.

@shannonhochkins
Copy link
Owner

Hey mate! Unfortunately, the types for all services are generated from the services schema which is incorrect in a few locations, this is a simple one I can implement something in the next release!

@shannonhochkins
Copy link
Owner

Fixed as of version 3.1.2 - types now defined as string | number as requested! For refernce - https://github.com/shannonhochkins/ha-component-kit/pull/115/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants