Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dataset selection independent on Data and Output tabs #73

Closed
shapiromatron opened this issue Dec 15, 2020 · 0 comments · Fixed by #77
Closed

Make dataset selection independent on Data and Output tabs #73

shapiromatron opened this issue Dec 15, 2020 · 0 comments · Fixed by #77
Assignees

Comments

@shapiromatron
Copy link
Owner

Currently the selected dataset on the Data and Output tabs are synced, that is, if a user changes the selected dataset on one tab, it persists in the other. Update so that tab changes are independent.

We'll likely keep the dataStore injection, but the input props will change so that these props which will come from the relevant store are passed in (eg; feel free to adjust):

<DatasetList
   selectedModelIndex={outputStore.selectedModelIndex}
   onChange={outputStore.handleSelectedDatasetChange} />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants