Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add street name to metadata tiles #9

Closed
kpwebb opened this issue Mar 6, 2018 · 3 comments
Closed

add street name to metadata tiles #9

kpwebb opened this issue Mar 6, 2018 · 3 comments

Comments

@kpwebb
Copy link
Member

kpwebb commented Mar 6, 2018

Proposed approach:

Add name field to OSMMetadata and WaySection elements. If only one version of the street name for all way sections the name goes in OSMMetadata otherwise we store each version in the WaySection and leave OSMMetadata blank. Open to suggestions on how to do this but goal is not to have tons of duplicate version of the street name for each reference.

@kpwebb
Copy link
Member Author

kpwebb commented Mar 10, 2018

added changes to builder in #11
Also updated proto buf spec to include names in sharedstreets/sharedstreets-ref-system/pull/18

@DenisCarriere
Copy link

👍 Names would be good, I doubt there will be a way to prevent duplicate names per each Reference. Including a name field seems very valuable.

@migurski
Copy link

This approach makes sense to me as well.

@kpwebb kpwebb closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants