-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo test thread panicked while panicking on 0.4.0 tarball #161
Comments
Thank you for reporting this. I can reproduce this. Not sure what is going on (currently investigating). |
Ok, this is due to the way we reset the fn undo_sample_file_modification() {
let output = Command::new("git")
.args(&["checkout", "--", "tests/snapshots/sample.rs"])
.output()
.expect("git checkout failed");
if !output.status.success() {
panic!("undoing modified sample changes failed")
}
} |
This should be fixed via v0.4.1. Thanks! |
Still getting the same error on 0.4.1. I've confirmed that the changes in 86c1777 are present, so not sure what's going on. |
I can not reproduce this. Could you please try to run cargo test -- --nocapture and send the output? |
I think I know why it's failing. Each AUR package is a git repo. When building a package the directory structure looks like this:
The So the snapshot test tries to run because it is in a git repo, just it's not the I'm going to update the package but I suppose it would be nice to be able to set end environment variable to skip the snapshot tests, even when in a Here is the output:
|
Fixed in bat 0.5. |
Hi I was just preparing to update the AUR package to 0.4.0. Part of the build process runs the tests via
cargo test
, which is failing. I tried a separate git checkout of the 0.4.0 tag andcargo test
worked. I then tried downloading the release tarball and building that by hand and it raises the error.System Info
Arch Linux x86_64
cargo 1.26.0 (0e7c5a931 2018-04-06)
rustc 1.26.1 (827013a31 2018-05-25)
Steps to Reproduce
cd bat-0.4.0
cargo test
Error
The text was updated successfully, but these errors were encountered: