Throws an error when bat is being user as pager.
#1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nill
reviewed
Oct 25, 2020
adrian-rivera
force-pushed
the
bat_pager
branch
2 times, most recently
from
aa7a547
to
188f008
Compare
keith-hall
reviewed
Oct 26, 2020
As mentioned on sharkdp#1334 `bat` should not be used as a value for `pager`, this change checks both the balue of `bat` provided as a parameter or as an environment variable.
adrian-rivera
force-pushed
the
bat_pager
branch
from
188f008
to
dd4b401
Compare
keith-hall
approved these changes
Oct 28, 2020
|
Fixed in bat v0.17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #1334
batshould not be used as a value forpager,this change checks both the balue of
batprovided as a parameter oras an environment variable.