Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Syntax Highlighting for Lean #1446

Merged
merged 3 commits into from
Jan 2, 2021
Merged

Add Syntax Highlighting for Lean #1446

merged 3 commits into from
Jan 2, 2021

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Dec 21, 2020

Hello --

Lean is an interactive theorem prover with a decent sized user base (e.g. its Zulip has... around 3,000 folks idling in it). No users really use Sublime Text, the vast majority of its users use VSCode, with a small subset using emacs (and an even smaller subset using other), so as I read it it likely doesn't meet the inclusion criteria, but just checking to be sure the above doesn't affect anything (it not really having any Sublime users). I'm sure you get a bunch of these, so certainly no hard feelings if you close it.

Thanks for bat!

Julian added a commit to Julian/dotfiles that referenced this pull request Dec 23, 2020
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

Could you please add a syntax test (see #1213 for instructions)?

doc/assets.md Show resolved Hide resolved
@Julian
Copy link
Contributor Author

Julian commented Jan 1, 2021

@sharkdp thanks for the review -- addressed I believe!

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sharkdp
Copy link
Owner

sharkdp commented Jan 2, 2021

Oh, one more thing. Could you please add a ChangeLog entry? See CONTRIBUTING.md for details. Nevermind, will do.

@sharkdp sharkdp merged commit af8a803 into sharkdp:master Jan 2, 2021
@Julian Julian deleted the lean branch January 2, 2021 12:22
@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2021

Added in bat v0.18.

Julian added a commit to Julian/dotfiles that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants